From b2d9b7745f724f605853bba0b413e27a367ac173 Mon Sep 17 00:00:00 2001
From: cn <cn@mycrobase.de>
Date: Tue, 28 Jul 2020 17:42:48 +0200
Subject: [PATCH] gem: bump minimum required Ruby version to Ruby 2.5

---
 .rubocop.yml                     | 3 ++-
 .travis.yml                      | 2 --
 CHANGELOG.md                     | 6 ++++++
 dyndnsd.gemspec                  | 4 ++--
 lib/dyndnsd/textfile_reporter.rb | 8 +++-----
 5 files changed, 13 insertions(+), 10 deletions(-)

diff --git a/.rubocop.yml b/.rubocop.yml
index 4e23acd..134a604 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -1,5 +1,6 @@
 AllCops:
-  TargetRubyVersion: '2.3'
+  TargetRubyVersion: '2.5'
+  NewCops: enable
 
 Layout/EmptyLineAfterGuardClause:
   Enabled: false
diff --git a/.travis.yml b/.travis.yml
index 2920897..4853706 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -5,8 +5,6 @@ rvm:
 - 2.7
 - 2.6
 - 2.5
-- 2.4
-- 2.3
 
 script:
 - bundle exec rake travis
diff --git a/CHANGELOG.md b/CHANGELOG.md
index d2ae79e..b4b1f78 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Changelog
 
+## 3.0.0
+
+IMPROVEMENTS:
+
+- Drop EOL Ruby 2.4 and lower support, now minimum version supported is Ruby 2.5
+
 ## 2.3.1 (July 27, 2020)
 
 IMPROVEMENTS:
diff --git a/dyndnsd.gemspec b/dyndnsd.gemspec
index 1409d0d..8f5e2a9 100644
--- a/dyndnsd.gemspec
+++ b/dyndnsd.gemspec
@@ -25,7 +25,7 @@ Gem::Specification.new do |s|
   s.executables = ['dyndnsd']
   s.extra_rdoc_files = Dir['README.md', 'CHANGELOG.md', 'LICENSE']
 
-  s.required_ruby_version = '>= 2.3'
+  s.required_ruby_version = '>= 2.5'
 
   s.add_runtime_dependency 'async-dns', '~> 1.2.0'
   s.add_runtime_dependency 'jaeger-client', '~> 0.10.0'
@@ -39,6 +39,6 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'rack-test'
   s.add_development_dependency 'rake'
   s.add_development_dependency 'rspec'
-  s.add_development_dependency 'rubocop', '~> 0.81.0'
+  s.add_development_dependency 'rubocop', '~> 0.82.0'
   s.add_development_dependency 'solargraph'
 end
diff --git a/lib/dyndnsd/textfile_reporter.rb b/lib/dyndnsd/textfile_reporter.rb
index e9da30c..e8842df 100644
--- a/lib/dyndnsd/textfile_reporter.rb
+++ b/lib/dyndnsd/textfile_reporter.rb
@@ -28,11 +28,9 @@ module Dyndnsd
           sleep @interval
 
           Thread.new do
-            begin
-              write
-            rescue StandardError => e
-              @on_error[e] rescue nil
-            end
+            write
+          rescue StandardError => e
+            @on_error[e] rescue nil
           end
         end
       end