1
0
mirror of https://github.com/cmur2/dyndnsd.git synced 2024-12-22 00:54:22 +01:00

Add coverage of IPv6 addresses in tests

This commit is contained in:
cn 2016-11-30 21:24:56 +01:00
parent cfce5be361
commit a9083e916e

View File

@ -2,11 +2,11 @@ require 'spec_helper'
describe Dyndnsd::Daemon do describe Dyndnsd::Daemon do
include Rack::Test::Methods include Rack::Test::Methods
def app def app
Dyndnsd.logger = Logger.new(STDOUT) Dyndnsd.logger = Logger.new(STDOUT)
Dyndnsd.logger.level = Logger::UNKNOWN Dyndnsd.logger.level = Logger::UNKNOWN
config = { config = {
'domain' => 'example.org', 'domain' => 'example.org',
'users' => { 'users' => {
@ -20,32 +20,32 @@ describe Dyndnsd::Daemon do
updater = Dyndnsd::Updater::Dummy.new updater = Dyndnsd::Updater::Dummy.new
responder = Dyndnsd::Responder::DynDNSStyle.new responder = Dyndnsd::Responder::DynDNSStyle.new
app = Dyndnsd::Daemon.new(config, db, updater, responder) app = Dyndnsd::Daemon.new(config, db, updater, responder)
Rack::Auth::Basic.new(app, "DynDNS") do |user,pass| Rack::Auth::Basic.new(app, "DynDNS") do |user,pass|
(config['users'].has_key? user) and (config['users'][user]['password'] == pass) (config['users'].has_key? user) and (config['users'][user]['password'] == pass)
end end
end end
it 'requires authentication' do it 'requires authentication' do
get '/' get '/'
last_response.status.should == 401 last_response.status.should == 401
pending 'Need to find a way to add custom body on 401 responses' pending 'Need to find a way to add custom body on 401 responses'
last_response.should be_ok 'badauth' last_response.should be_ok 'badauth'
end end
it 'only supports GET requests' do it 'only supports GET requests' do
authorize 'test', 'secret' authorize 'test', 'secret'
post '/nic/update' post '/nic/update'
last_response.status.should == 405 last_response.status.should == 405
end end
it 'provides only the /nic/update URL' do it 'provides only the /nic/update URL' do
authorize 'test', 'secret' authorize 'test', 'secret'
get '/other/url' get '/other/url'
last_response.status.should == 404 last_response.status.should == 404
end end
it 'requires the hostname query parameter' do it 'requires the hostname query parameter' do
authorize 'test', 'secret' authorize 'test', 'secret'
get '/nic/update' get '/nic/update'
@ -55,85 +55,112 @@ describe Dyndnsd::Daemon do
it 'supports multiple hostnames in request' do it 'supports multiple hostnames in request' do
authorize 'test', 'secret' authorize 'test', 'secret'
get '/nic/update?hostname=foo.example.org,bar.example.org&myip=1.2.3.4' get '/nic/update?hostname=foo.example.org,bar.example.org&myip=1.2.3.4'
last_response.should be_ok last_response.should be_ok
last_response.body.should == "good 1.2.3.4\ngood 1.2.3.4" last_response.body.should == "good 1.2.3.4\ngood 1.2.3.4"
get '/nic/update?hostname=foo.example.org,bar.example.org&myip=2001:db8::1'
last_response.should be_ok
last_response.body.should == "good 2001:db8::1\ngood 2001:db8::1"
end end
it 'rejects request if one hostname is invalid' do it 'rejects request if one hostname is invalid' do
authorize 'test', 'secret' authorize 'test', 'secret'
get '/nic/update?hostname=test' get '/nic/update?hostname=test'
last_response.should be_ok last_response.should be_ok
last_response.body.should == 'notfqdn' last_response.body.should == 'notfqdn'
get '/nic/update?hostname=test.example.com' get '/nic/update?hostname=test.example.com'
last_response.should be_ok last_response.should be_ok
last_response.body.should == 'notfqdn' last_response.body.should == 'notfqdn'
get '/nic/update?hostname=test.example.org.me' get '/nic/update?hostname=test.example.org.me'
last_response.should be_ok last_response.should be_ok
last_response.body.should == 'notfqdn' last_response.body.should == 'notfqdn'
get '/nic/update?hostname=foo.test.example.org' get '/nic/update?hostname=foo.test.example.org'
last_response.should be_ok last_response.should be_ok
last_response.body.should == 'notfqdn' last_response.body.should == 'notfqdn'
get '/nic/update?hostname=in%20valid.example.org' get '/nic/update?hostname=in%20valid.example.org'
last_response.should be_ok last_response.should be_ok
last_response.body.should == 'notfqdn' last_response.body.should == 'notfqdn'
get '/nic/update?hostname=valid.example.org,in.valid.example.org' get '/nic/update?hostname=valid.example.org,in.valid.example.org'
last_response.should be_ok last_response.should be_ok
last_response.body.should == 'notfqdn' last_response.body.should == 'notfqdn'
end end
it 'rejects request if user does not own one hostname' do it 'rejects request if user does not own one hostname' do
authorize 'test', 'secret' authorize 'test', 'secret'
get '/nic/update?hostname=notmyhost.example.org' get '/nic/update?hostname=notmyhost.example.org'
last_response.should be_ok last_response.should be_ok
last_response.body.should == 'nohost' last_response.body.should == 'nohost'
get '/nic/update?hostname=foo.example.org,notmyhost.example.org' get '/nic/update?hostname=foo.example.org,notmyhost.example.org'
last_response.should be_ok last_response.should be_ok
last_response.body.should == 'nohost' last_response.body.should == 'nohost'
end end
it 'updates a host on IPv4 change' do it 'updates a host on IP change' do
authorize 'test', 'secret' authorize 'test', 'secret'
get '/nic/update?hostname=foo.example.org&myip=1.2.3.4' get '/nic/update?hostname=foo.example.org&myip=1.2.3.4'
last_response.should be_ok last_response.should be_ok
get '/nic/update?hostname=foo.example.org&myip=1.2.3.40' get '/nic/update?hostname=foo.example.org&myip=1.2.3.40'
last_response.should be_ok last_response.should be_ok
last_response.body.should == 'good 1.2.3.40' last_response.body.should == 'good 1.2.3.40'
get '/nic/update?hostname=foo.example.org&myip=2001:db8::1'
last_response.should be_ok
get '/nic/update?hostname=foo.example.org&myip=2001:db8::10'
last_response.should be_ok
last_response.body.should == 'good 2001:db8::10'
end end
it 'returns IPv4 no change' do it 'returns IP no change' do
authorize 'test', 'secret' authorize 'test', 'secret'
get '/nic/update?hostname=foo.example.org&myip=1.2.3.4' get '/nic/update?hostname=foo.example.org&myip=1.2.3.4'
last_response.should be_ok last_response.should be_ok
get '/nic/update?hostname=foo.example.org&myip=1.2.3.4' get '/nic/update?hostname=foo.example.org&myip=1.2.3.4'
last_response.should be_ok last_response.should be_ok
last_response.body.should == 'nochg 1.2.3.4' last_response.body.should == 'nochg 1.2.3.4'
get '/nic/update?hostname=foo.example.org&myip=2001:db8::1'
last_response.should be_ok
get '/nic/update?hostname=foo.example.org&myip=2001:db8::1'
last_response.should be_ok
last_response.body.should == 'nochg 2001:db8::1'
end end
it 'outputs IPv4 status per hostname' do it 'outputs IP status per hostname' do
authorize 'test', 'secret' authorize 'test', 'secret'
get '/nic/update?hostname=foo.example.org&myip=1.2.3.4' get '/nic/update?hostname=foo.example.org&myip=1.2.3.4'
last_response.should be_ok last_response.should be_ok
last_response.body.should == 'good 1.2.3.4' last_response.body.should == 'good 1.2.3.4'
get '/nic/update?hostname=foo.example.org,bar.example.org&myip=1.2.3.4' get '/nic/update?hostname=foo.example.org,bar.example.org&myip=1.2.3.4'
last_response.should be_ok last_response.should be_ok
last_response.body.should == "nochg 1.2.3.4\ngood 1.2.3.4" last_response.body.should == "nochg 1.2.3.4\ngood 1.2.3.4"
get '/nic/update?hostname=foo.example.org&myip=2001:db8::1'
last_response.should be_ok
last_response.body.should == 'good 2001:db8::1'
get '/nic/update?hostname=foo.example.org,bar.example.org&myip=2001:db8::1'
last_response.should be_ok
last_response.body.should == "nochg 2001:db8::1\ngood 2001:db8::1"
end end
it 'uses clients remote IPv4 address if myip not specified' do it 'uses clients remote IP address if myip not specified' do
authorize 'test', 'secret' authorize 'test', 'secret'
get '/nic/update?hostname=foo.example.org' get '/nic/update?hostname=foo.example.org'
last_response.should be_ok last_response.should be_ok