Refactor V2 and V3 parser into one

lib/openvpn-status-web/parser/modern_stateless.rb

@@ -0,0 +1,22 @@
+
+module OpenVPNStatusWeb
+  module Parser
+    class ModernStateless
+      def self.parse_status_log(text, sep)
+        status = Status.new
+        status.client_list = []
+        status.routing_table = []
+        status.global_stats = []
+
+        text.lines.each do |line|
+          parts = line.strip.split(sep)
+          status.client_list << parts[1..5] if parts[0] == "CLIENT_LIST"
+          status.routing_table << parts[1..4] if parts[0] == "ROUTING_TABLE"
+          status.global_stats << parts[1..2] if parts[0] == "GLOBAL_STATS"
+        end
+
+        status
+      end
+    end
+  end
+end

lib/openvpn-status-web/parser/v2.rb

@@ -1,24 +1,11 @@
 
+require 'openvpn-status-web/parser/modern_stateless'
+
 module OpenVPNStatusWeb
   module Parser
     class V2
       def parse_status_log(text)
-        client_list = []
-        routing_table = []
-        global_stats = []
-
-        text.lines.each do |line|
-          parts = line.strip.split(',')
-          client_list << parts[1..5] if parts[0] == "CLIENT_LIST"
-          routing_table << parts[1..4] if parts[0] == "ROUTING_TABLE"
-          global_stats << parts[1..2] if parts[0] == "GLOBAL_STATS"
-        end
-
-        status = Status.new
-        status.client_list = client_list
-        status.routing_table = routing_table
-        status.global_stats = global_stats
-        status
+        OpenVPNStatusWeb::Parser::ModernStateless.parse_status_log(text, ',')
       end
     end
   end

lib/openvpn-status-web/parser/v3.rb

@@ -0,0 +1,12 @@
+
+require 'openvpn-status-web/parser/modern_stateless'
+
+module OpenVPNStatusWeb
+  module Parser
+    class V3
+      def parse_status_log(text)
+        OpenVPNStatusWeb::Parser::ModernStateless.parse_status_log(text, "\t")
+      end
+    end
+  end
+end